Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of comments, libraries and interfaces #438

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Review of comments, libraries and interfaces #438

merged 6 commits into from
Aug 25, 2023

Conversation

QGarchery
Copy link
Contributor

No description provided.

@QGarchery QGarchery requested review from a team August 24, 2023 13:03
@QGarchery QGarchery self-assigned this Aug 24, 2023
@QGarchery QGarchery requested review from Rubilmax, MerlinEgalite, pakim249CAL, Jean-Grimal, makcandrov, peyha and MathisGD and removed request for a team August 24, 2023 13:03
@QGarchery QGarchery mentioned this pull request Aug 24, 2023
Closed
MerlinEgalite
MerlinEgalite requested changes Aug 24, 2023
View reviewed changes
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
QGarchery
QGarchery commented Aug 24, 2023
View reviewed changes
src/Morpho.sol Outdated Show resolved Hide resolved
src/Morpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Show resolved Hide resolved
src/interfaces/IMorpho.sol Show resolved Hide resolved
src/libraries/EventsLib.sol Show resolved Hide resolved
src/libraries/MathLib.sol Show resolved Hide resolved
Rubilmax
Rubilmax reviewed Aug 24, 2023
View reviewed changes
src/libraries/MathLib.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax previously approved these changes Aug 24, 2023
View reviewed changes
pakim249CAL
pakim249CAL previously approved these changes Aug 24, 2023
View reviewed changes
MathisGD
MathisGD previously approved these changes Aug 25, 2023
View reviewed changes
src/interfaces/IMorpho.sol Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Aug 25, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite merged commit f5c4ebb into main Aug 25, 2023
4 checks passed
@MerlinEgalite MerlinEgalite deleted the refactor/general-review branch August 25, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@makcandrov makcandrov Awaiting requested review from makcandrov makcandrov was automatically assigned from morpho-labs/onchain

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-labs/protocol

@pakim249CAL pakim249CAL Awaiting requested review from pakim249CAL

@MathisGD MathisGD Awaiting requested review from MathisGD

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@QGarchery @Rubilmax @MerlinEgalite @pakim249CAL @MathisGD @Jean-Grimal